Fix docstring of zaxis_date. #18587
Merged
Fix docstring of zaxis_date. #18587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The docstring of zaxis_date appends an addendum to the other axis_dates (about the fact that it doesn't actually work...), but previously the docstring appending incorrectly went to `_axis_method_wrapper.__doc__`, not `zaxis_date.__doc__`. Perform docstring interpolation earlier to fix that.
f19d7b6 to
ba959ec
Compare
dopplershift
approved these changes
Sep 28, 2020
QuLogic
approved these changes
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docstring of zaxis_date appends an addendum to the other axis_dates
(about the fact that it doesn't actually work...), but previously the
docstring appending incorrectly went to
_axis_method_wrapper.__doc__,not
zaxis_date.__doc__. Perform docstring interpolation earlier tofix that.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).