Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Text cleanups. #18586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Text cleanups. #18586

merged 1 commit into from
Sep 28, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Sep 26, 2020

Fix the docstring of _get_textbox. (Text.get_extents doesn't exist.)

Inline _draw_bbox into its sole call site (the first half is the same
as update_bbox_position_size; this does mean calling
convert_xunits/convert_yunits twice but that should be cheap compared
to everything else).

Annotation.draw doesn't need to also call update_bbox_position_size
as Text.draw will do it (I think the call was duplicated because the
draw-a-bbox functionality was present in Annotation before it also moved
to Text).

rcParams -> mpl.rcParams.

Remove an extraneous import.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and pydocstyle<4 and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).

Fix the docstring of _get_textbox.  (`Text.get_extents` doesn't exist.)

Inline `_draw_bbox` into its sole call site (the first half is the same
as `update_bbox_position_size`; this does mean calling
`convert_xunits/convert_yunits` twice but that should be cheap compared
to everything else).

`Annotation.draw` doesn't need to also call `update_bbox_position_size`
as `Text.draw` will do it (I think the call was duplicated because the
draw-a-bbox functionality was present in Annotation before it also moved
to Text).

rcParams -> mpl.rcParams.

Remove an extraneous import.
@dopplershift dopplershift merged commit a3ebc54 into matplotlib:master Sep 28, 2020
@dopplershift dopplershift added this to the v3.4.0 milestone Sep 28, 2020
@anntzer anntzer deleted the textclean branch September 28, 2020 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.