Remove extra stickies in barstacked histogram. #18464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we let stacked bars add their sticky edges in the middle of the bars, margin expansion can later bump into these barriers.
anntzer
commented
Sep 12, 2020
| @@ -6660,13 +6660,19 @@ def hist(self, x, bins=None, range=None, density=False, weights=None, | ||
| height = m - bottom | ||
| else: | ||
| height = m | ||
| patch = _barfunc(bins[:-1]+boffset, height, width, |
There was a problem hiding this comment.
(this is actually a BarCollection object, not a Patch...)
jklymak
approved these changes
Sep 12, 2020
|
This would be fine remilestoned to 3.3.2 if it get sin sooner |
timhoffm
approved these changes
Sep 13, 2020
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Sep 13, 2020
timhoffm
added a commit
that referenced
this pull request
Sep 13, 2020
…464-on-v3.3.x Backport PR #18464 on branch v3.3.x (Remove extra stickies in barstacked histogram.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we let stacked bars add their sticky edges in the middle of the bars,
margin expansion can later bump into these barriers.
Closes #18457.
PR Summary
PR Checklist
pytestpasses).flake8on changed files to check).flake8-docstringsandpydocstyle<4and runflake8 --docstring-convention=all).doc/users/next_whats_new/(follow instructions in README.rst there).doc/api/next_api_changes/(follow instructions in README.rst there).