Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Add on_toggle method instead of enable/disable in ToolToggleBase #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
Loading
from
Draft

Add on_toggle method instead of enable/disable in ToolToggleBase #18332

wants to merge 2 commits into from

Conversation

Ptrskay3
Copy link
Contributor

Related to #18331 .

PR Summary

Changed trigger in ToolToggleBase to call on_toggle(state, event) whenever the state of self._toggled changes. Also it is backward compatible with enable(event) and disable(event). Additionally I changed ToolFullScreen, AxisScaleBase and ZoomPanBase to use the new on_toggle method.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@Ptrskay3 Ptrskay3 marked this pull request as draft August 25, 2020 10:12
@anntzer
Copy link
Contributor

anntzer commented Aug 27, 2020

Thanks for the PR. I'll leave it to others to decide whether we do want the API change first, or at least comment on it, before looking at the actual implementation.

@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Aug 18, 2023
@anntzer
Copy link
Contributor

anntzer commented Aug 23, 2023

I'll rebase and finish fixing that PR, but that'll go on top of #26580 as it turns out some tools shouldn't be toggles after all.

@anntzer anntzer mentioned this pull request Aug 23, 2023
Open
@github-actions github-actions bot removed the status: inactive Marked by the “Stale” Github Action label Aug 25, 2023
@github-actions
Copy link

Since this Pull Request has not been updated in 60 days, it has been marked "inactive." This does not mean that it will be closed, though it may be moved to a "Draft" state. This helps maintainers prioritize their reviewing efforts. You can pick the PR back up anytime - please ping us if you need a review or guidance to move the PR forward! If you do not plan on continuing the work, please let us know so that we can either find someone to take the PR over, or close it.

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Oct 25, 2023
@anntzer
Copy link
Contributor

anntzer commented Oct 25, 2023

Still blocked by #26580, but the idea is correct I think.

@anntzer anntzer added keep Items to be ignored by the “Stale” Github Action and removed status: inactive Marked by the “Stale” Github Action labels Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
API: changes keep Items to be ignored by the “Stale” Github Action MEP: MEP22 tool manager status: needs rebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ptrskay3 @anntzer
Morty Proxy This is a proxified and sanitized view of the page, visit original site.