Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add parent widget to IntVar #18260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

richardsheridan
Copy link
Contributor

@richardsheridan richardsheridan commented Aug 14, 2020

PR Summary

Fixes #18259. The code for reproduction in there might be suitable to become a test if we add a more complete set of widgets. At the moment with this fix my NoDefaultRoot app is working fine.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/next_api_changes/* if API changed in a backward-incompatible way

@jklymak
Copy link
Member

jklymak commented Aug 14, 2020

Not a Tk expert, but this seems fine...

@jklymak jklymak added this to the v3.4.0 milestone Aug 14, 2020
@jklymak jklymak merged commit 3abdfa9 into matplotlib:master Aug 14, 2020
@QuLogic
Copy link
Member

QuLogic commented Aug 14, 2020

@meeseekdev backport to v3.3.x

@QuLogic QuLogic modified the milestones: v3.4.0, v3.3.2 Aug 14, 2020
@QuLogic
Copy link
Member

QuLogic commented Aug 14, 2020

Helps to spell it right.
@meeseeksdev backport to v3.3.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Aug 14, 2020
QuLogic added a commit that referenced this pull request Aug 14, 2020
…260-on-v3.3.x

Backport PR #18260 on branch v3.3.x (Add parent widget to IntVar)
@richardsheridan richardsheridan deleted the intvar_parent_fix branch August 14, 2020 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New IntVar needs a parent widget
4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.