Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Cleanup wx examples. #17400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 13, 2020
Merged

Cleanup wx examples. #17400

merged 1 commit into from
May 13, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 13, 2020

  • Move toplevel code under if __name__ == "__main__" block. (This
    makes sense specifically for embedding examples as they have very
    little toplevel code and are indeed otherwise "importable".)
  • Replace App(0) by App() (the argument defaults to False).
  • Replace Show(1) by Show() (the arguments defaults to True).

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Cleanup wx examples.
7a8be18 
- Move toplevel code under `if __name__ == "__main__"` block.  (This
  makes sense specifically for embedding examples as they have very
  little toplevel code and are indeed otherwise "importable".)
- Replace App(0) by App() (the argument defaults to False).
- Replace Show(1) by Show() (the arguments defaults to True).
@timhoffm timhoffm added this to the v3.3.0 milestone May 13, 2020
@timhoffm timhoffm merged commit 54bd6f1 into matplotlib:master May 13, 2020
@anntzer anntzer deleted the wxex branch May 13, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation GUI: wx
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.