Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Also use light color tool buttons in qt+toolmanager+dark theme. #17365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 8, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented May 8, 2020

... by reusing the logic of NavigationToolbar2QT.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... by reusing the logic of NavigationToolbar2QT.
@anntzer anntzer added MEP: MEP22 tool manager GUI: Qt labels May 8, 2020
@QuLogic
Copy link
Member

QuLogic commented May 8, 2020

So this means they aren't inverted, or are inverted? Can you post a screenshot?

@anntzer
Copy link
Contributor Author

anntzer commented May 8, 2020

before:
before
after:
after

Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I understand what's happening now.

@QuLogic QuLogic merged commit b8083ec into matplotlib:master May 8, 2020
@QuLogic QuLogic added this to the v3.3.0 milestone May 8, 2020
@anntzer anntzer deleted the qtoolmancolors branch May 8, 2020 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.