Simplify pickling support. #17297
Merged
Simplify pickling support. #17297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- silent_list is directly picklable as is; no need to do anything about it. While we're at it, also get rid of `__str__` -- `__str__` is documented to fall back on `__repr__`, so the latter is sufficient. - When pickling GridSpec and SubplotSpec, set _layoutbox to None, so that no special loading is needed.
timhoffm
approved these changes
May 1, 2020
QuLogic
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it. While we're at it, also get rid of
__str__--__str__isdocumented to fall back on
__repr__, so the latter is sufficient.that no special loading is needed.
PR Summary
PR Checklist