Fix bug where matplotlib.style('default') resets the backend #17252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you do plain |
49638cd to
23470a8
Compare
|
Nope that works fine. Just changed it. |
tacaswell
approved these changes
Apr 28, 2020
QuLogic
approved these changes
Apr 28, 2020
|
Thanks @lukelbd! |
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Apr 28, 2020
…') resets the backend
QuLogic
added a commit
that referenced
this pull request
Apr 28, 2020
…252-on-v3.2.x Backport PR #17252 on branch v3.2.x (Fix bug where matplotlib.style('default') resets the backend)
|
Congratulations on your first Matplotlib PR 🎉 ! Hopefully we will hear from you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This is a two-line PR that fixes an issue where
matplotlib.style('default')resets the backend.While
matplotlib.style._remove_blacklisted_style_paramstries to prevent resetting the backend, it fails due to the implementation ofRcParams.__getitem__. Basically these lines:matplotlib/lib/matplotlib/style/core.py
Lines 45 to 47 in 002b27e
end up triggering these lines when the
'backend'key comes up:matplotlib/lib/matplotlib/__init__.py
Lines 697 to 701 in 002b27e
To repair this, I change the
_remove_blacklisted_style_paramsiteration fromfor key, val in d.items()tofor key in d.keys():, which prevents triggering the__getitem__override.PR Checklist