Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Deprecate support for running svg converter from path containing newline. #17211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2020
Merged

Deprecate support for running svg converter from path containing newline. #17211

merged 1 commit into from
Apr 28, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 22, 2020

Inkscape's batch mode doesn't handle newlines(!) in file names, which
tbh doesn't seem to be a too big restriction in practice. Right now we
fallback on a specific path to handle that case, but I doubt that it is
really hit, given that the batch ghostscript converter likely has the
same limitation (since #9454) and no one complained about it for two years.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Apr 22, 2020
@anntzer
Copy link
Contributor Author

anntzer commented Apr 27, 2020

rebased

@tacaswell
Copy link
Member

It looks like this logic came in via 8c66203 what inspired you to put in this bit of paranoia @anntzer ?

@anntzer
Copy link
Contributor Author

anntzer commented Apr 28, 2020

I guess I was just being extra extra careful; OTOH if glib's g_shell_parse_argv doesn't support that I doubt we need to bother... (or we can just redirect complaints to glib :))

@anntzer
Deprecate support for running svg converter from path contaning newline.
b2b7d09 
Inkscape's batch mode doesn't handle newlines(!) in file names, which
tbh doesn't seem to be a too big restriction in practice.  Right now we
fallback on a specific path to handle that case, but I doubt that it is
really hit, given that the batch ghostscript converter likely has the
same limitation and no one complained about it for two years.
@tacaswell
Copy link
Member

The travis failure is the log_nonpos test being flaky on mac again (this time failing to read, not image comparison failures). Restarted, anyone can merge on green.

@QuLogic QuLogic merged commit 5455bab into matplotlib:master Apr 28, 2020
@anntzer anntzer deleted the svgnl branch April 28, 2020 22:25
@QuLogic QuLogic changed the title Deprecate support for running svg converter from path contaning newline. Deprecate support for running svg converter from path containing newline. Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
backend: svg topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.