Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

DOC/FIX: clarify the docs for check_figures_equal #16940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2020
Merged

DOC/FIX: clarify the docs for check_figures_equal #16940

merged 2 commits into from
Mar 31, 2020

Conversation

tacaswell
Copy link
Member

PR Summary

Clarify that the names matter and add a check with a better exception.

closes #16916

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant

@tacaswell tacaswell added this to the v3.2.2 milestone Mar 27, 2020
QuLogic
QuLogic reviewed Mar 29, 2020
View reviewed changes
lib/matplotlib/testing/decorators.py Outdated Show resolved Hide resolved
lib/matplotlib/tests/test_testing.py Outdated Show resolved Hide resolved
@tacaswell
DOC/FIX: clarify the docs for check_figures_equal
b0d63b5 
Clarify that the names matter and add a check with a better exception.

closes matplotlib#16916
@tacaswell tacaswell force-pushed the doc_compare_figures_equal branch from d2328fe to b0d63b5 Compare March 30, 2020 03:37
@tacaswell
Copy link
Member Author

@QuLogic both comments addressed.

timhoffm
timhoffm reviewed Mar 30, 2020
View reviewed changes
lib/matplotlib/testing/decorators.py Outdated Show resolved Hide resolved
@tacaswell @timhoffm
MNT: use simpler set opretaions
0a33534 
Co-Authored-By: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
timhoffm
timhoffm approved these changes Mar 30, 2020
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Anybody can merge after CI pass.

@QuLogic
Copy link
Member

QuLogic commented Mar 30, 2020

This test_too_many_date_ticks seems a bit painful, timing out on macOS before and now it's crashing on AppVeyor.

@tacaswell
Copy link
Member Author

Opened #16973 to try and make that test more efficent.

@QuLogic QuLogic merged commit b01325c into matplotlib:master Mar 31, 2020
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 31, 2020
@QuLogic @meeseeksmachine
Backport PR matplotlib#16940: DOC/FIX: clarify the docs for check_fig…
2ce7057 
…ures_equal
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 31, 2020
Merged
QuLogic added a commit that referenced this pull request Mar 31, 2020
@QuLogic
Merge pull request #16974 from meeseeksmachine/auto-backport-of-pr-16…
39e5589 
…940-on-v3.2.x

Backport PR #16940 on branch v3.2.x (DOC/FIX: clarify the docs for check_figures_equal)
@tacaswell tacaswell deleted the doc_compare_figures_equal branch May 6, 2021 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@anntzer anntzer anntzer approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: testing
Projects
None yet
Milestone
v3.2.2
Development

Successfully merging this pull request may close these issues.

check_figures_equal regression from 3.2.0 to 3.2.1
4 participants
@tacaswell @QuLogic @anntzer @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.