Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

use validate_[cap/join]style #16850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2020
Merged

Conversation

brunobeltran
Copy link
Contributor

@brunobeltran brunobeltran commented Mar 20, 2020

PR Summary

Something trivial I found while scrolling around making sure I covered every join/capstyle we allow. Currently, collections.py, rcparams.py, and lines.py all have their own way of checking whether a cap/join-style is valid (patches.py uses the code from lines.py). These all boil down to a cbook._check_in_list, but some forget to warn that case-insensitivity is deprecated.

Since rcparams.py seems like the centralized place for checking that parameters are valid, I had them all call rcparams.validate_[cap|join]style() instead. This correctly warns for deprecated case-insensitivity.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

lib/matplotlib/patches.py Show resolved Hide resolved
lib/matplotlib/collections.py Outdated Show resolved Hide resolved
@anntzer anntzer added this to the v3.3.0 milestone Mar 20, 2020
@dstansby dstansby merged commit ef9fc20 into matplotlib:master Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.