Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Cleanup demo_axes_hbox_divider. #16774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 26, 2020
Merged

Cleanup demo_axes_hbox_divider. #16774

merged 1 commit into from
Mar 26, 2020

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 14, 2020

  • Small rewording.
  • Use the make_heights_equal function demo'ed in the example, rather
    than copy-pasting it.
  • For the central annotation, use a figure-level text() instead of an
    invisible axes.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added this to the v3.3.0 milestone Mar 14, 2020
@QuLogic
Copy link
Member

QuLogic commented Mar 26, 2020

Looks like the reference didn't work.

@anntzer
Cleanup demo_axes_hbox_divider.
de54b03 
- Small rewording.
- Use the make_heights_equal function demo'ed in the example, rather
  than copy-pasting it.
- For the central annotation, use a figure-level text() instead of an
  invisible axes.
@anntzer
Copy link
Contributor Author

anntzer commented Mar 26, 2020

Bad capitalization, hopefully fixed now...

@QuLogic QuLogic merged commit 5713554 into matplotlib:master Mar 26, 2020
@anntzer anntzer deleted the hbd branch March 26, 2020 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

Assignees
No one assigned
Labels
Documentation topic: mpl_toolkit
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@anntzer @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.