Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

bugfix issue 16501 raised ValueError when creating a polar subplot with (thetamax - thetamin) > 2pi #16711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 7 commits into from
Closed

bugfix issue 16501 raised ValueError when creating a polar subplot with (thetamax - thetamin) > 2pi #16711

wants to merge 7 commits into from

Conversation

prasadve
Copy link
Contributor

@prasadve prasadve commented Mar 8, 2020 •
edited
Loading

PR Summary:

This PR addresses issue #16501 set_thetalim takes in parameters as radians or degrees but the problem occurs when the range or difference between the parameters is large than 2pi radians or larger than 360 in terms of degrees. The polar subplot will produce a deformed graph as it is shown in the Github issue 16501.

Fix: The fix was done using a check for ranges larger than 2pi, and if so ValueError is raised

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@story645
Copy link
Member

story645 commented Mar 8, 2020

Hi, can you please edit the title to be more descriptive of which bug you're fixing and briefly add a summary explaining how you fixed the bug? Reviewers don't want to have to refer back to the issue to decide whether they should review your code.

@prasadve prasadve changed the title bugfix issue 16501 bugfix issue 16501 raised ValueError when creating a polar subplot with (thetamax - thetamin) > 2pi Mar 8, 2020
@prasadve
Copy link
Contributor Author

prasadve commented Mar 8, 2020 •
edited
Loading

@story645 Sorry, this is my first time submitting a PR for Matplotlib, but here are the details below

Summary: set_thetalim takes in parameters as radians or degrees but the problem occurs when the range or difference between the parameters is large than 2pi radians or larger than 360 in terms of degrees. The polar subplot will produce a deformed graph as it is shown in the Github issue 16501.

Fix: The fix was done using a check for ranges larger than 2pi, and if so ValueError is raised

@anntzer anntzer mentioned this pull request Mar 9, 2020
Closed
@AbithanK
Merge pull request #1 from CSCD01-team13/5496-Fix-default-checkbox-fo…
753044c 
…r-legend

Changed default value of checkbox to be always checked in QT_editor backend
@prasadve
Copy link
Contributor Author

Closing this PR as I opened another pull request with different source branch. Check link: #16717

@prasadve prasadve closed this Mar 10, 2020
@prasadve prasadve mentioned this pull request Mar 10, 2020
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: duplicate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@prasadve @story645 @QuLogic @AbithanK
Morty Proxy This is a proxified and sanitized view of the page, visit original site.