Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

typo in ticker.ScalarFormatter doc #16355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

typo in ticker.ScalarFormatter doc #16355

merged 1 commit into from
Jan 28, 2020

Conversation

elehcim
Copy link
Contributor

@elehcim elehcim commented Jan 28, 2020

It was inconsistent with the example in ticker.ScalarFormatter.set_powerlimits

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@elehcim
typo in ticker.ScalarFormatter doc
651e335 
It was inconsistent with the example in `ticker.ScalarFormatter.set_powerlimits`
@elehcim elehcim requested a review from anntzer January 28, 2020 16:49
@anntzer anntzer removed their request for review January 28, 2020 16:52
story645
story645 approved these changes Jan 28, 2020
View reviewed changes
Copy link
Member

@story645 story645 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this and putting in the pull request!

@timhoffm timhoffm added this to the v2.2.5 milestone Jan 28, 2020
@timhoffm timhoffm merged commit cc96303 into matplotlib:master Jan 28, 2020
@lumberbot-app
Copy link

lumberbot-app bot commented Jan 28, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v2.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 cc963039cb6c669204ad2e564e6ab8eb4355fafe
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16355: typo in `ticker.ScalarFormatter` doc'
  1. Push to a named branch :
git push YOURFORK v2.2.x:auto-backport-of-pr-16355-on-v2.2.x
  1. Create a PR against branch v2.2.x, I would have named this PR:

"Backport PR #16355 on branch v2.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 28, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 cc963039cb6c669204ad2e564e6ab8eb4355fafe
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16355: typo in `ticker.ScalarFormatter` doc'
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-16355-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #16355 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Jan 28, 2020

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 cc963039cb6c669204ad2e564e6ab8eb4355fafe
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am 'Backport PR #16355: typo in `ticker.ScalarFormatter` doc'
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-16355-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #16355 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@timhoffm
Copy link
Member

timhoffm commented Feb 3, 2020

Meanwhile, v3.2.0 has been tagged, and I don't think, it's essential to backport this.

@timhoffm timhoffm modified the milestones: v2.2.5, v3.3.0 Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@story645 story645 story645 approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@elehcim @timhoffm @story645 @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.