Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Name Axes variables ax instead of a #16109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

Name Axes variables ax instead of a #16109

merged 1 commit into from
Jan 6, 2020

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Jan 5, 2020 •
edited
Loading

PR Summary

For consistency.

  • Axes are typically named ax not a.
  • Figures are typically named fig not f.
  • Shortend the Ellipse Demo.

@timhoffm timhoffm added this to the v3.3.0 milestone Jan 5, 2020
anntzer
anntzer reviewed Jan 5, 2020
View reviewed changes
lib/matplotlib/pyplot.py Outdated Show resolved Hide resolved
anntzer
anntzer reviewed Jan 5, 2020
View reviewed changes
lib/matplotlib/pyplot.py Outdated Show resolved Hide resolved
anntzer
anntzer reviewed Jan 5, 2020
View reviewed changes
examples/shapes_and_collections/ellipse_demo.py Outdated Show resolved Hide resolved
anntzer
anntzer approved these changes Jan 5, 2020
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs ci.
Some minor additional suggestions.

@timhoffm timhoffm force-pushed the ax-naming branch 2 times, most recently from fb75aaa to 5fd6c2f Compare January 5, 2020 20:20
@timhoffm
Consistently name Axes and Figure variables
2aa91e4 
- Axes are typically named ax not a
- Figures are typically named fig not f
- some other variable cleanup
- shortened the Ellipse Demo
@jklymak jklymak merged commit 3752aec into matplotlib:master Jan 6, 2020
@timhoffm timhoffm deleted the ax-naming branch January 6, 2020 19:50
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Aug 25, 2020
@QuLogic
Remove redundant angles in ellipse demo.
5d74edb 
Since ellipses are 180°-symmetric, they're actually overplotted twice
(and 3 times for 0° before matplotlib#16109.)
@QuLogic QuLogic mentioned this pull request Aug 25, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic left review comments

@anntzer anntzer anntzer approved these changes

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Maintenance
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@timhoffm @QuLogic @anntzer @jklymak
Morty Proxy This is a proxified and sanitized view of the page, visit original site.