Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Skip webagg test if tornado is not available. #15763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2019
Merged

Skip webagg test if tornado is not available. #15763

merged 1 commit into from
Dec 10, 2019

Conversation

QuLogic
Copy link
Member

@QuLogic QuLogic commented Nov 23, 2019

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • [N/A] New features are documented, with examples if plot related
  • [N/A] Documentation is sphinx and numpydoc compliant
  • [N/A] Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • [N/A] Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@QuLogic QuLogic added this to the v3.2.0 milestone Nov 23, 2019
@anntzer
Copy link
Contributor

anntzer commented Nov 23, 2019

I'm confused -- were the tests failing before if run on an env without tornado installed?

@QuLogic
Copy link
Member Author

QuLogic commented Nov 24, 2019

Yes, for example, this other webagg test skips if tornado is not installed.

Though now that I look at it, this test also touches nbagg, so I will fix the skip to only run on webagg.

@anntzer
Copy link
Contributor

anntzer commented Nov 24, 2019

Actually nbagg depends on webagg_core (one imports the other) and thus on tornado, so I think always skipping (the previous version) is correct?

@QuLogic
Copy link
Member Author

QuLogic commented Nov 25, 2019

Oops, I think you're right. We don't install IPython, so I misunderstood the skip.

@tacaswell tacaswell merged commit 6251c52 into matplotlib:master Dec 10, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Dec 10, 2019
@tacaswell
Backport PR matplotlib#15763: Skip webagg test if tornado is not avai…
2f73248 
…lable.
@meeseeksmachine meeseeksmachine mentioned this pull request Dec 10, 2019
Merged
timhoffm added a commit that referenced this pull request Dec 10, 2019
@timhoffm
Merge pull request #15905 from meeseeksmachine/auto-backport-of-pr-15…
e2a49d6 
…763-on-v3.2.x

Backport PR #15763 on branch v3.2.x (Skip webagg test if tornado is not available.)
@QuLogic QuLogic deleted the skip-webagg branch December 12, 2019 03:34
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jan 13, 2020
@tacaswell @meeseeksmachine
Backport PR matplotlib#15763: Skip webagg test if tornado is not avai…
9997e28 
…lable.
@meeseeksmachine meeseeksmachine mentioned this pull request Jan 13, 2020
Merged
@tacaswell tacaswell modified the milestones: v3.2.0, v3.1.3 Jan 13, 2020
timhoffm added a commit that referenced this pull request Jan 14, 2020
@timhoffm
Merge pull request #16213 from meeseeksmachine/auto-backport-of-pr-15…
dc2da1d 
…763-on-v3.1.x

Backport PR #15763 on branch v3.1.x (Skip webagg test if tornado is not available.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
GUI: webagg topic: testing
Projects
None yet
Milestone
v3.1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@QuLogic @anntzer @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.