Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Don't mention tcl in tkagg comments anymore. #15671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 11, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Nov 11, 2019

... as we don't rely on any Tcl_* functions anymore.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

... as we don't rely on any Tcl_* functions anymore.
@timhoffm timhoffm modified the milestones: v3.1-doc, v3.1.2 Nov 11, 2019
@timhoffm timhoffm merged commit ab932d1 into matplotlib:master Nov 11, 2019
@lumberbot-app
Copy link

lumberbot-app bot commented Nov 11, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.1.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ab932d1d5d9871b3c37c8f7d977fdf523db0d963
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am "Backport PR #15671: Don't mention tcl in tkagg commments anymore."
  1. Push to a named branch :
git push YOURFORK v3.1.x:auto-backport-of-pr-15671-on-v3.1.x
  1. Create a PR against branch v3.1.x, I would have named this PR:

"Backport PR #15671 on branch v3.1.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@lumberbot-app
Copy link

lumberbot-app bot commented Nov 11, 2019

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
$ git checkout v3.2.x
$ git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
$ git cherry-pick -m1 ab932d1d5d9871b3c37c8f7d977fdf523db0d963
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
$ git commit -am "Backport PR #15671: Don't mention tcl in tkagg commments anymore."
  1. Push to a named branch :
git push YOURFORK v3.2.x:auto-backport-of-pr-15671-on-v3.2.x
  1. Create a PR against branch v3.2.x, I would have named this PR:

"Backport PR #15671 on branch v3.2.x"

And apply the correct labels and milestones.

Congratulation you did some good work ! Hopefully your backport PR will be tested by the continuous integration and merged soon!

If these instruction are inaccurate, feel free to suggest an improvement.

@anntzer anntzer deleted the tkcomments branch November 11, 2019 13:15
@tacaswell tacaswell modified the milestones: v3.1.2, v3.3.0 Nov 11, 2019
@tacaswell
Copy link
Member

I'm not super worried about back porting comments is c code to older branches. They are not user-facing and have been out-dated for a while.

@QuLogic QuLogic changed the title Don't mention tcl in tkagg commments anymore. Don't mention tcl in tkagg comments anymore. Aug 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.