Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Make sure that figures are closed when check_figures_equal finishes #15589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2019
Merged

Make sure that figures are closed when check_figures_equal finishes #15589

merged 1 commit into from
Nov 2, 2019

Conversation

MarcoGorelli
Copy link
Contributor

PR Summary

fixes #15079. Closes figures after check_figures_equal has finished so that different tests don't overwrite each others' figures.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer approved these changes Nov 2, 2019
View reviewed changes
Copy link
Contributor

@anntzer anntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be rather painful to test because one would need to disable the "figure-autoclose" autofixture to see any effects, so I think this can go in without tests.

@dopplershift dopplershift merged commit 4ddf004 into matplotlib:master Nov 2, 2019
@MarcoGorelli MarcoGorelli deleted the close-plots-in-check-figures-equal branch November 2, 2019 17:32
@tacaswell tacaswell added this to the v3.3.0 milestone Nov 2, 2019
This was referenced Mar 16, 2020
Merged
Merged
QuLogic added a commit that referenced this pull request Mar 17, 2020
@QuLogic
Merge pull request #16797 from QuLogic/backport-checkfigeq
3ee24e5 
Backport #15589 and #16693, fixes for check_figures_equal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dopplershift dopplershift dopplershift approved these changes

@anntzer anntzer anntzer approved these changes

Assignees
No one assigned
Labels
mentored: hackathon topic: testing
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.

check_figures_equal decorator reuses figures if called multiple times inside a single test.
4 participants
@MarcoGorelli @dopplershift @anntzer @tacaswell
Morty Proxy This is a proxified and sanitized view of the page, visit original site.