Geo projections getting clobbered by 2to3 when used when python3 #1555
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. "lon" and "lat" is much nicer than "long" and "lat" anyway. |
|
Woah. Nice catch, @joferkington! This PR looks fine to me too. I'll merge this tomorrow. Thanks again. |
|
👍 |
|
Thanks. This should be cherry-picked for |
|
Merging. @mdboom Sure thing. |
dmcdougall
added a commit
that referenced
this pull request
Dec 4, 2012
Geo projections getting clobbered by 2to3 when used when python3
|
Cherry-pickled: 40d28e0 |
|
Thanks a bunch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
projections/geo.pyuseslongas a variable name in many places. This is replaced withintby 2to3, which leads to problems (e.g.foo = int * barinstead offoo = long * bar).Steps to reproduce:
examples/api/custom_projection_example.py