Correctly setup comparisons in test_compare_images. #15263
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copy the baseline images to the results directory, to avoid the "QPixmap::scaled: Pixmap is a null pixmap" error from triage_tests.py.
anntzer
commented
Sep 13, 2019
| actual = convert(actual, False) | ||
| expected = convert(expected, True) | ||
| actual = convert(actual, cache=False) | ||
| expected = convert(expected, cache=True) |
There was a problem hiding this comment.
(not directly related, but this is clearer and I was going through compare_images to try to understand the source of the warning...)
timhoffm
approved these changes
Sep 14, 2019
jklymak
approved these changes
Sep 14, 2019
|
@timhoffm Not anything measurable for me (and I don't see why it should, either). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy the baseline images to the results directory, to avoid the
"QPixmap::scaled: Pixmap is a null pixmap" error from triage_tests.py.
PR Summary
PR Checklist