In findfont(fallback_to_default=False), throw if default font is missing #15249
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing. ... instead of entering an infinite loop of findfont -> defaultFont -> findfont. A bit of a pain to test (one needs to delete dejavusans both from the mpl source tree and from the system font folder)... This should only affect people who delete the default fonts anyways (or call with fallback_to_default=False), so I'll skip the API change note.
a398ef2 to
8a543b5
Compare
timhoffm
approved these changes
Sep 11, 2019
QuLogic
approved these changes
Sep 12, 2019
|
@QuLogic is there a reason that you approve but don’t merge? |
|
The build needed restarting. |
|
Since v3.2.0 is not yet branched would this still go in 3.2.0? what is the branch policy? Do we just branch from master at some point or do we branch from some previous commit so that current master is already targeting 3.3.0? |
|
3.2.0 was branched https://github.com/matplotlib/matplotlib/tree/v3.2.x It was announced yesterday. |
|
👍 Never mind, maybe I've just checked an old brower tab. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... instead of entering an infinite loop of findfont -> defaultFont ->
findfont.
A bit of a pain to test (one needs to delete dejavusans both from the
mpl source tree and from the system font folder)...
This should only affect people who delete the default fonts anyways (or
call with fallback_to_default=False), so I'll skip the API change note.
Closes https://gitter.im/matplotlib/matplotlib?at=5d78acdd767de913fcbda27c.
PR Summary
PR Checklist