Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Deprecate trying to set minor ticks in 3D #15003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

timhoffm
Copy link
Member

@timhoffm timhoffm commented Aug 7, 2019

PR Summary

they are not supported anyway. It's better to warn now and fail in the future than to silently do nothing. The ultimate plan is to drop the minor parameter in the future so that we have a clean API at least.

  • Also changes the signature of set_zticks(*args, **kwargs) to to explicit parameters.
  • Also marks the Axes as stale for set_zticks (set_xticks/yticks does this already).

Inspired from user problems in #14980.

@timhoffm timhoffm force-pushed the axes3d-minor-ticks branch from 702d242 to 5599b98 Compare August 7, 2019 19:24
@anntzer
Copy link
Contributor

anntzer commented Aug 7, 2019

#14626 adds support for minor ticks in 3d axes.

@timhoffm
Copy link
Member Author

timhoffm commented Aug 7, 2019

🐑 Is that ready for review?

@anntzer
Copy link
Contributor

anntzer commented Aug 7, 2019

Yes.

@timhoffm
Copy link
Member Author

timhoffm commented Aug 7, 2019

Obsolete because of #14626.

@timhoffm timhoffm closed this Aug 7, 2019
@timhoffm timhoffm deleted the axes3d-minor-ticks branch August 7, 2019 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.