Only allow set_adjustable("datalim") for axes with standard data ratios. #14835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bf5eb3f to
d283c37
Compare
timhoffm
approved these changes
Jul 17, 2019
If an Axes subclass overrides get_data_ratio to anything else than
"ratio of data limits after application of scales" (e.g. Polar always
returns 1), then the data limits manipulation in apply_aspect won't
achieve the proper data ratio anyways, so disable setting adjustable to
"datalim" in that case.
For example, calling `axis("equal")` on polar axes (which also sets
adjustable to "datalim") will now error out instead of resulting in a
nonsensical plot.
d283c37 to
2cc8e14
Compare
|
Seems good to me; querying @efiring because he is trying to keep this stuff consistent. |
efiring
approved these changes
Jul 17, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an Axes subclass overrides get_data_ratio to anything else than
"ratio of data limits after application of scales" (e.g. Polar always
returns 1), then the data limits manipulation in apply_aspect won't
achieve the proper data ratio anyways, so disable setting adjustable to
"datalim" in that case.
For example, calling
axis("equal")on polar axes (which also setsadjustable to "datalim") will now error out instead of resulting in a
nonsensical plot.
Closes #14608.
PR Summary
PR Checklist