Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Add explanations for single character color names. #14718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 9, 2019

Conversation

bingyao
Copy link
Contributor

@bingyao bingyao commented Jul 8, 2019

PR Summary

Main changes in 3 files:

  • lib/matplotlib/_color_data.py: add comments for single character color names.
  • lib/matplotlib/colors.py: add explanations for single character color names in docstring;
  • tutorials/colors/colors.py: sync the color descriptions with the lib/matplotlib/colors.py

@bingyao bingyao force-pushed the more_explicit_colors_names branch from 8a218a0 to 782626a Compare July 8, 2019 09:41
lib/matplotlib/_color_data.py Outdated Show resolved Hide resolved
@bingyao bingyao force-pushed the more_explicit_colors_names branch from 782626a to 9da2435 Compare July 9, 2019 01:34
@timhoffm timhoffm merged commit b34895d into matplotlib:master Jul 9, 2019
@timhoffm
Copy link
Member

timhoffm commented Jul 9, 2019

Thanks!

@timhoffm timhoffm added this to the v3.2.0 milestone Jul 9, 2019
@bingyao bingyao deleted the more_explicit_colors_names branch July 29, 2019 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.