Further simplify colormap reversal. #14679
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
story645
reviewed
Jul 3, 2019
timhoffm
reviewed
Jul 3, 2019
Instead of implementing reversal of colormaps in the various formats in `_cm` and `_cm_listed`, we can just rely on Colormap.reversed() to do the job... `revcmap` was a public helper to a private function (`_reverse_cmap_spec`) so I'm not too worried with deprecating it. The private `_reverser` gets deprecated rather than deleted because `revcmap` depends on it. The `cmapname` toplevel variable used to leak out of the loop; I deleted it without deprecation or notice and moved cmap generation to a private function to avoid such leakage. The `datad` global now no longer contains "unconverted" entries for reversed cmaps (as not generating them is the whole point of the PR...); I'm not even sure it's worth an API note...
timhoffm
approved these changes
Jul 4, 2019
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of implementing reversal of colormaps in the various formats
in
_cmand_cm_listed, we can just rely on Colormap.reversed() to dothe job...
revcmapwas a public helper to a private function(
_reverse_cmap_spec) so I'm not too worried with deprecating it. Theprivate
_reversergets deprecated rather than deleted becauserevcmapdepends on it.The
cmapnametoplevel variable used to leak out of the loop; I deletedit without deprecation or notice and moved cmap generation to a private
function to avoid such leakage.
The
datadglobal now no longer contains "unconverted" entries forreversed cmaps (as not generating them is the whole point of the PR...);
I'm not even sure it's worth an API note...
Followup to #14674 (when I wrote #14674 I didn't realize this could be made much simpler).
PR Summary
PR Checklist