Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Update some widget docstrings. #14659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 13, 2019
Merged

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jun 30, 2019

PR Summary

The usual docstring churn.

Edit: looks like links in the "Methods" section need revisiting.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way


image : array, mpl image, Pillow Image
Copy link
Contributor Author

@anntzer anntzer Jun 30, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"mpl images" are not a thing anymore since https://github.com/matplotlib/matplotlib/pull/5718/files#diff-327a40694cf498b1dd5e3f2ec0eed955.

The name "PIL Image" is consistent with e.g. imshow()'s docstring.

lib/matplotlib/widgets.py Show resolved Hide resolved
lib/matplotlib/widgets.py Outdated Show resolved Hide resolved
@tacaswell tacaswell added this to the v3.2.0 milestone Jul 2, 2019
@tacaswell tacaswell modified the milestones: v3.2.0, v3.3.0 Aug 27, 2019
@anntzer anntzer force-pushed the widgetdocs branch 2 times, most recently from 363c296 to 9d5f7f0 Compare December 12, 2019 23:00
@anntzer
Copy link
Contributor Author

anntzer commented Dec 13, 2019

should be good to go now

@timhoffm timhoffm merged commit bb64740 into matplotlib:master Dec 13, 2019
@anntzer anntzer deleted the widgetdocs branch December 13, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.