Support unicode minus with ps.useafm. #14484
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Jun 8, 2019
lib/matplotlib/afm.py
Outdated
| @@ -244,6 +244,8 @@ def _parse_char_metrics(fh): | ||
| # Reference). | ||
| if name == 'Euro': | ||
| num = 128 | ||
| if name == 'minus': |
There was a problem hiding this comment.
Suggested change
| if name == 'minus': | |
| elif name == 'minus': |
Just to be a bit more explicit.
Really, the whole postscript font encoding system should be rethought,
but for now, given that there's already special casing for \N{EURO
SIGN}, I don't feel too bad adding another special case for \N{MINUS
SIGN}.
Note that the test has a `if not mpl.rcParams["text.usetex"]` clause
because `\N{MINUS SIGN}` + usetex + useafm doesn't work yet...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Really, the whole postscript font encoding system should be rethought,
but for now, given that there's already special casing for \N{EURO
SIGN}, I don't feel too bad adding another special case for \N{MINUS
SIGN}.
Note that the test has a
if not mpl.rcParams["text.usetex"]clausebecause
\N{MINUS SIGN}+ usetex + useafm doesn't work yet...Closes #9127.
PR Summary
PR Checklist