Simplify implementation of svg.image_inline. #14454
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
reviewed
Jun 8, 2019
There was a problem hiding this comment.
Not tested, but could a user change basename? E.g.
renderer.basename = 'file_a'
renderer.draw_image()
renderer.basename = 'file_b'
renderer.draw_image()
Until now he would have gotten file_a0, file_b0.
Now it will be file_a0, file_b1.
We could still have a dict of counters per basename if we want to keep that compatibility exactly.
8737b3e to
19f00e5
Compare
|
timhoffm
approved these changes
Jun 8, 2019
RendererSVG._imaged is basically a single-entry dict (because Renderer.basename never changes), so just replace it by a counter. Also replace the assert by a proper exception, and only trigger it if the user actually tries to save an image while the filesystem path is unknown (otherwise, there's no problem).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RendererSVG._imaged is basically a single-entry dict (because
Renderer.basename never changes), so just replace it by a counter.
Also replace the assert by a proper exception, and only trigger it if
the user actually tries to save an image while the filesystem path is
unknown (otherwise, there's no problem).
The whole svg.image_inline system could probably use a test...
PR Summary
PR Checklist