Backport PR #14295: Fix bug in SymmetricalLogTransform. #14317
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why does this commit show up as authored by @NelleV? I basically followed the directions in the meeseeksdev bot message for manually backporting. |
|
I merged the PR? |
|
Yes, that must be it; it's just not what I was expecting to see, especially since there were conflicts I had to resolve in the backport, so I'm the one who should be blamed if I messed it up. |
|
We both are authors, so comes to it, we'll share the blame 🙂
…On Fri, May 24, 2019, 8:33 PM Eric Firing ***@***.***> wrote:
Yes, that must be it; it's just not what I was expecting to see,
especially since there were conflicts I had to resolve in the backport, so
I'm the one who should be blamed if I messed it up.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#14317?email_source=notifications&email_token=AABNDXXLFM7DDQRITY454GTPXCCPJA5CNFSM4HPTGQG2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODWGZYTQ#issuecomment-495819854>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABNDXRWFTIMFMPRLZUL5ILPXCCPJANCNFSM4HPTGQGQ>
.
|
|
The instructions from meeseeksbot are for cherry-picking the merge commit, as it doesn't backport a multi-commit PR individually (which may or may not work so easily). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
PR Checklist