Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Simplify setup for msbuild in Windows FreeType build. #14028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Apr 24, 2019

The trick is to use ccompiler.new_compiler().spawn which will take
care of locating setenv.cmd / vcvarsall, invoking them, and finding the
correct path to msbuild.exe.

This is essentially the same approach as used by mplcairo.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

The trick is to use `ccompiler.new_compiler().spawn` which will take
care of locating setenv.cmd / vcvarsall, invoking them, and finding the
correct path to msbuild.exe.

This is essentially the same approach as used by mplcairo.
@anntzer
Copy link
Contributor Author

anntzer commented Oct 4, 2019

Merged as part of #13077.

@anntzer anntzer closed this Oct 4, 2019
@anntzer anntzer deleted the msvc branch October 4, 2019 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant
Morty Proxy This is a proxified and sanitized view of the page, visit original site.