Deprecate mlab.{apply_window,stride_repeat}. #13987
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Altogether, they take more than 100 lines of implementation and many hundred lines of tests, for what amounts to an array multiplication optionally preceded by calling a user-supplied callable (see how apply_window is inlined in _spectral_helper; stride_repeat is strictly a helper for apply_window).
|
Looks good to me. It looks like codecov isn't working for any of your PRs, is there any chance you could take a look into why? |
|
Actually it's at https://codecov.io/gh/matplotlib/matplotlib/commit/b57c39af1ff295d29cf80bdd227b238106a8b6e8, though I don't know why github did not link it. |
|
Odd, I wonder why it's not working just for you? |
dstansby
approved these changes
Apr 19, 2019
tacaswell
reviewed
Apr 20, 2019
| @@ -520,29 +522,34 @@ def _spectral_helper(x, y=None, NFFT=None, Fs=None, detrend_func=None, | ||
| numFreqs = pad_to//2 + 1 | ||
| scaling_factor = 2. | ||
|
|
||
| if not np.iterable(window): |
There was a problem hiding this comment.
would if callbable(window) make more sense?
There was a problem hiding this comment.
The logic is the same in apply_window, I don't think handling the behavior change is worth it...
tacaswell
approved these changes
Apr 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Altogether, they take more than 100 lines of implementation and many
hundred lines of tests, for what amounts to an array multiplication
optionally preceded by calling a user-supplied callable (see how
apply_window is inlined in _spectral_helper; stride_repeat is strictly a
helper for apply_window).
PR Summary
PR Checklist