Remove unused autolayout_validator() from rcsetup #1389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| def validate_autolayout(v): | ||
| if v: | ||
| warnings.warn("figure.autolayout is not currently supported") | ||
|
|
There was a problem hiding this comment.
Can you just add one extra blank lines for pep8 purposes? I haven't yet pep8-ised this file, but this will help !
|
I think this is fine. We can save the spacing issue until this file is PEP8-ized. |
mdboom
added a commit
that referenced
this pull request
Oct 15, 2012
Remove unused autolayout_validator() from rcsetup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
figure.autolayout is now being handled by validate_bool, so the original autolayout_validator, which warned that figure.autolayout had no function, is unused.