Deprecate factor=None in axisartist. #13876
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhoffm
approved these changes
Apr 4, 2019
|
Needs a rebase. |
mpl_toolkits.axisartist has its own notion of Locators and Formatters (which have a different API from standard Locators and Formatters); in particular, they have a notion of "factor" -- either a numeric value, or None, which is treated equivalently to 1. Simplify a bit axisartist by deprecating support for None (as 1 is synonym and is handled by the more general code).
|
done |
122afb5 to
e900be3
Compare
efiring
approved these changes
Apr 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mpl_toolkits.axisartist has its own notion of Locators and Formatters
(which have a different API from standard Locators and Formatters); in
particular, they have a notion of "factor" -- either a numeric value, or
None, which is treated equivalently to 1.
Simplify a bit axisartist by deprecating support for None (as 1 is
synonym and is handled by the more general code).
PR Summary
PR Checklist