-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Improve website navigation bar #13808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"Modules" is now duplicate https://19829-1385122-gh.circle-artifacts.com/0/home/circleci/project/doc/build/html/index.html The right one comes somehow through the sphinx template mechanism. Note that we'll probably have to rework the sphinx template anyway (either due to sphinx 2.0 #13591 or as part of a more complete documentation structure overhaul #13796 (comment)). So I personally, wouldn't bother too much with this single link now. |
🤷♂️ I think it's an improvement, and having an obvious link but a duplicate is better than not having an obvious link. |
Hm, I don't think having two links with the same name but different targets adds to the clarity. But I don't care too much since I assume that this will be reworked anyway in the near future. |
I'm not a big fan of the term "module." IMO, it's unclear what it is and should be folded into the API menu. |
(I had to click on module in order to understand what the link was about) |
@@ -39,7 +39,7 @@ Further reading: | ||
plotting functions. | ||
- Most of the :ref:`examples <examples-index>` use the object-oriented approach | ||
(except for the pyplot section) | ||
- The list of :doc:`matplotlib modules </api/index>`. | ||
- The list of :doc:`Mwatplotlib modules </api/index>`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The list of :doc:`Mwatplotlib modules </api/index>`. | |
- The list of :doc:`Matplotlib modules </api/index>`. |
Perhaps "submodules"(/"subpackages")? |
I think this is covered by #14176 now, so I'm going to close. |
Fixes #13796 - I've also capitalised the entries.