Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Remove duplicated methods in FixedAxisArtistHelper. #13737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2019
Merged

Remove duplicated methods in FixedAxisArtistHelper. #13737

merged 1 commit into from
Mar 24, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 22, 2019

These are copy-pasted from the same methods in the parent class
FloatingAxisArtistHelper.

Also cleanup a bit the base method implementation.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer
Remove duplicated methods in FixedAxisArtistHelper.
0c96f77 
These are copy-pasted from the same methods in the parent class
FloatingAxisArtistHelper.

Also cleanup a bit the base method implementation.
@QuLogic QuLogic merged commit 6f49999 into matplotlib:master Mar 24, 2019
@QuLogic QuLogic added this to the v3.2.0 milestone Mar 24, 2019
@anntzer anntzer deleted the inherit branch March 24, 2019 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
topic: mpl_toolkit
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @QuLogic @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.