Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Check for already running QApplication in Qt embedding example. #13731

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 22, 2019

PR Summary

Closes (part of) #13400.
I decided against calling QtWidgets.QApplication.setQuitOnLastWindowClosed(True) because this was explicitly set from IPython (https://github.com/ipython/ipykernel/blob/master/ipykernel/eventloops.py#L117) so it seems counterproductive to undo their choice here. The default is already true (https://doc.qt.io/qt-5/qguiapplication.html#quitOnLastWindowClosed-prop) so we should generally assume that if someone set it to false, they know what they're doing.

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@jklymak jklymak merged commit 24e4bea into matplotlib:master Mar 25, 2019
@anntzer anntzer deleted the qt-check-qapp branch March 25, 2019 13:57
@QuLogic QuLogic added this to the v3.2.0 milestone Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.