Remove What's new fancy example #13685
Conversation
426ca74 to
d9bd2db
Compare
3dc86b3 to
17087c9
Compare
17087c9 to
0d68436
Compare
|
that'll break the links at https://matplotlib.org/users/prev_whats_new/whats_new_0.98.4.html#fancy-annotations-and-arrows I think... (probably can be fixed using |
0d68436 to
681493e
Compare
|
Links fixed. Not by using |
|
My preference would be to leave the 0.98.4 whatsnew page appear as it does (so with a ..plot::). The duplication is not really a problem; in my view the whatsnew is just a snapshot of how matplotlib was when 0.98.4 was released. |
|
@anntzer I've added a The change is in a second commit, to be able to undo just in case. Squash if you like. |
|
doc build is failing, probably needs a rebase? would let me see the sizing problem on circleci :) |
d13d437 to
377f649
Compare
|
|
||
| .. _psd-amplitude: | ||
| figheight = 8 | ||
| fig = plt.figure(figsize=(9, figheight), dpi=80) |
There was a problem hiding this comment.
You can perhaps change the size here? Dunno, but perhaps worth trying?
There was a problem hiding this comment.
I've reduced the size, but that needed more parameter changes. Now, it's a smaller version as desired. Drawbacks:
- The result is left aligned whereas all other plots are centered.
- This preserves the bad layout of the original example.
I don't care too much if we take this or my first proposal with the links to up-to-date examples.
There was a problem hiding this comment.
I wouldn't worry about the layout, the changelog entry is what it is.
The left-alignment wouldn't be a problem if we also move the other two examples to inline in the whatsnew :p
|
I'll let you self-merge with or without squashing first (#13685 (comment)), up to you. |
PR Summary
Remove
https://matplotlib.org/gallery/pyplots/whats_new_98_4_fancy.html
which is redundant with
https://matplotlib.org/gallery/shapes_and_collections/fancybox_demo.html
https://matplotlib.org/gallery/text_labels_and_annotations/fancyarrow_demo.html
and the latter have already better styling.