Use format_data_short to format image cursor data. #13684
Merged
+20
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Despite its name, format_data_short is actually used to format the x/y cursor data; it makes sense to also use it for image data. By doing so, e.g. for `imshow([[.123, .987]])`, one gets the more accurate `.123` string when the mouse is over the first pixel instead of `.1` that `__call__` returns (which would have been intended as a tick label).
tacaswell
approved these changes
Mar 17, 2019
timhoffm
approved these changes
Mar 17, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 17, 2019
timhoffm
added a commit
that referenced
this pull request
Mar 17, 2019
…684-on-v3.1.x Backport PR #13684 on branch v3.1.x (Use format_data_short to format image cursor data.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Despite its name, format_data_short is actually used to format the x/y
cursor data; it makes sense to also use it for image data. By doing so,
e.g. for
imshow([[.123, .987]]), one gets the more accurate.123string when the mouse is over the first pixel instead of
.1that__call__returns (which would have been intended as a tick label).Release critical as an improvement over #12459.
PR Summary
PR Checklist