Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Remove axes border for examples that list styles #13683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

timhoffm
Copy link
Member

PR Summary

This removes the axes border from the linestyle and joinstyle examples.

This brings these examples visually closer to other examples that list the possible values of a parameter e.g.
https://matplotlib.org/devdocs/gallery/lines_bars_and_markers/marker_fillstyle_reference.html
https://matplotlib.org/devdocs/gallery/lines_bars_and_markers/marker_reference.html
https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/fancyarrow_demo.html
https://matplotlib.org/devdocs/gallery/text_labels_and_annotations/usetex_fonteffects.html
https://matplotlib.org/devdocs/gallery/color/named_colors.html

Having no border is a nice visual hint that these examples are not primarily an example plot.

@@ -66,17 +65,16 @@ def plot_angle(ax, x, y, angle, style):
ax.set_title('Cap style')

for x, style in enumerate(['butt', 'round', 'projecting']):
ax.text(x, 1, style)
ax.text(x+0.25, 1, style, ha='center')
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additionally centered the texts.

@timhoffm timhoffm force-pushed the example-axes-border branch from df1d290 to 07325e2 Compare March 17, 2019 12:49
@timhoffm timhoffm force-pushed the example-axes-border branch from 07325e2 to 96625f0 Compare March 17, 2019 16:23
Copy link
Member

@ImportanceOfBeingErnest ImportanceOfBeingErnest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a nice improvement.

@ImportanceOfBeingErnest ImportanceOfBeingErnest merged commit 34970ed into matplotlib:master Mar 17, 2019
@timhoffm timhoffm deleted the example-axes-border branch March 17, 2019 19:36
@QuLogic QuLogic added this to the v3.2.0 milestone Jul 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.