BLD: parameterize python_requires #13637
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only write the minimum version 1 place instead of 3
jklymak
reviewed
Mar 8, 2019
| @@ -11,14 +11,16 @@ | ||
| from setuptools.command.test import test as TestCommand | ||
| from setuptools.command.build_ext import build_ext as BuildExtCommand | ||
|
|
||
| if sys.version_info < (3, 6): | ||
| min_version = (3, 6) | ||
|
|
There was a problem hiding this comment.
Did you want to just define min_ver_str = '.'.join(str(n) for n in min_version) here, and use that below? EDIT: You could then use f-strings: (Ooops that was dumb, since you wouldn't print these if f strings were allowed)
`f"...Python {min_ver_str} or above is required"
There was a problem hiding this comment.
Would be slightly better. I‘ll wait a day or so to see if there‘s feedback. Otherwise I will merge as is. You can always do a follow up if you feel inclined.
There was a problem hiding this comment.
Or
min_version = distutils.version.LooseVersion("3.6.0")
if platform.python_version() < min_version: ...
...
python_requires=">={}".format(min_version)
QuLogic
reviewed
Mar 8, 2019
Co-Authored-By: tacaswell <tcaswell@gmail.com>
dstansby
approved these changes
Mar 9, 2019
timhoffm
approved these changes
Mar 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only write the minimum version 1 place instead of 3