Fix polar get window extent #13614
Merged
Fix polar get window extent #13614
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuLogic
reviewed
Mar 7, 2019
| @@ -20,6 +20,7 @@ | ||
|
|
||
| """ | ||
|
|
||
| from __future__ import division |
There was a problem hiding this comment.
We don't need this unless you're backported to 2.2.x?
| ax = [] | ||
| fig1, axs = plt.subplots(rows, cols, figsize=figsize, constrained_layout=True) | ||
| axs = axs.flat | ||
| axs[-1].remove() # not used... |
There was a problem hiding this comment.
That depends on the length of cases, doesn't it?
There was a problem hiding this comment.
something like for ax in axs[:len(cases)]: ax.remove() after converting to axs.flat looks better to me, perhaps have a helper function.
| ax.append(fig1.add_subplot(gs[row, col])) | ||
| ax[-1].set_title('markevery=%s' % str(case)) | ||
| ax[-1].plot(x, y, 'o', ls='-', ms=4, markevery=case) | ||
| ax = axs[i] |
There was a problem hiding this comment.
for ax, case in zip(axs, cases): (don't think i is used for anything here now.)
| fig4 = plt.figure(num=4, figsize=figsize) | ||
| axpolar = [] | ||
| fig4, axs = plt.subplots(rows, cols, figsize=figsize, | ||
| subplot_kw = {'projection':'polar'}, constrained_layout=True) |
timhoffm
approved these changes
Mar 7, 2019
|
Added a test that fails on master: and passes w/ this PR.... |
75cd5fd to
bda7c19
Compare
|
@tacaswell re-milestoned, but feel free to re-milestone back. Maybe my mistake for mixing two things in the PR, but this fixes a real bug in getting the tightbbox from polar axes... |
bda7c19 to
e297810
Compare
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 11, 2019
jklymak
added a commit
that referenced
this pull request
Mar 11, 2019
…614-on-v3.1.x Backport PR #13614 on branch v3.1.x (Fix polar get window extent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
This PR does 2 things. First, cleans up
markerevery_demoto use modern semantics; Second, catches an error inspines.get_window_extentthat can happen if the spine has no axis.PR Checklist