Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Cleanup two font-related examples. #13582

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 4, 2019
Merged

Cleanup two font-related examples. #13582

merged 1 commit into from
Mar 4, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 3, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

timhoffm
timhoffm reviewed Mar 4, 2019
View reviewed changes
examples/misc/font_indexing.py Outdated Show resolved Hide resolved
QuLogic
QuLogic approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@QuLogic QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just fix the above comment.

timhoffm
timhoffm approved these changes Mar 4, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modulo the comment. Anybody can merge after fixing that.

@anntzer
Copy link
Contributor Author

anntzer commented Mar 4, 2019

thanks, fixed

@dstansby dstansby added this to the v3.1.0 milestone Mar 4, 2019
@dstansby dstansby merged commit 5f6df5b into matplotlib:master Mar 4, 2019
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Mar 4, 2019
@dstansby
Backport PR matplotlib#13582: Cleanup two font-related examples.
bb9b8fe
@meeseeksmachine meeseeksmachine mentioned this pull request Mar 4, 2019
Merged
@anntzer anntzer deleted the font-examples branch March 4, 2019 14:23
dstansby added a commit that referenced this pull request Mar 4, 2019
@dstansby
Merge pull request #13584 from meeseeksmachine/auto-backport-of-pr-13…
abbbe61 
…582-on-v3.1.x

Backport PR #13582 on branch v3.1.x (Cleanup two font-related examples.)
@anntzer anntzer mentioned this pull request Mar 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QuLogic QuLogic QuLogic approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@anntzer @QuLogic @timhoffm @dstansby
Morty Proxy This is a proxified and sanitized view of the page, visit original site.