Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Conversation

@dstansby
Copy link
Member

@dstansby dstansby commented Feb 8, 2019

A subset of #13369, only the ones where removing the colours altogether is fine in my opinion.

Copy link
Member

@jklymak jklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, other than the small suggestion. I think if color can have a meaning its useful, OTOH, I'm not sure a gendered example is the best place to showcase that meaning ;-)

fig, ax = plt.subplots()
rects1 = ax.bar(ind - width/2, men_means, width, yerr=men_std,
color='SkyBlue', label='Men')
label='Men')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe sexist, but one could argue that the colors had gender associations that help in reading the chart....

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but blue/light red have are often deemed masculine/feminine. OTOH, I don't really feel strongly we need to perpetuate that.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, which is why I removed the explicit colours.

@jklymak jklymak merged commit bd99dfb into matplotlib:master Feb 9, 2019
@QuLogic QuLogic added this to the v3.1.0 milestone Feb 9, 2019
@dstansby dstansby deleted the ex-remove-colours branch February 9, 2019 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Morty Proxy This is a proxified and sanitized view of the page, visit original site.