Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Spelling fixes. #13307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2019
Merged

Spelling fixes. #13307

merged 1 commit into from
Jan 28, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jan 28, 2019

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

anntzer
anntzer commented Jan 28, 2019
View reviewed changes
lib/matplotlib/patches.py
@@ -4054,7 +4054,6 @@ def __init__(self, posA=None, posB=None,

elif posA is None and posB is None and path is not None:
self._posA_posB = None
self._connetors = None
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not used anywhere.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this:

sharon@12:05  ➤  git grep _connetors
lib/matplotlib/patches.py:            self._connetors = None

@tacaswell tacaswell merged commit a55909a into matplotlib:master Jan 28, 2019
@anntzer anntzer deleted the spell branch January 28, 2019 17:23
@QuLogic QuLogic added this to the v3.1 milestone Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@anntzer @tacaswell @QuLogic
Morty Proxy This is a proxified and sanitized view of the page, visit original site.