Shorten setupext and remove uninformative build log entries. #13262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The version check in setupext is unnecessary as we're already checking
at the very top of setup.py (note that no one even bothered updating
the version value in setupext...).
- The InstallRequires can be merged e.g. into Matplotlib, which removes
two completely uninformative lines from the build log
```
REQUIRED DEPENDENCIES AND EXTENSIONS
install_requires: yes [handled by setuptools]
```
- Changing the message widths and indents (which was only possible after
removing the "install_requires" entry in the log) allows fitting the
python version, in the common linux case, on a single line:
```
python: yes [3.7.2 (default, Jan 10 2019, 23:51:51) [GCC 8.2.1 20181127]]
```
instead of
```
python: yes [3.7.2 (default, Jan 10 2019, 23:51:51) [GCC 8.2.1
20181127]]
```
timhoffm
approved these changes
Jan 22, 2019
NelleV
reviewed
Jan 23, 2019
| @@ -167,18 +167,18 @@ def is_min_version(found, minversion): | ||
| # Define the display functions only if display_status is True. | ||
| if options['display_status']: | ||
| def print_line(char='='): | ||
| print(char * 79) | ||
| print(char * 80) |
There was a problem hiding this comment.
to match the message width below... for which the change is explained in the commit/PR message.
jklymak
approved these changes
Feb 7, 2019
|
Merging - If there really is concern about the allowed line width, we can revert that. My suspicion is that if it make @anntzer happy it won't bother anyone else... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at the very top of setup.py (note that no one even bothered updating
the version value in setupext...).
two completely uninformative lines from the build log
removing the "install_requires" entry in the log) allows fitting the
python version, in the common linux case, on a single line:
instead of
PR Summary
PR Checklist