BUG: calculate colorbar boundaries correctly from values #13114
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes matplotlib#13098. The unusual case of a call to colorbar with specified values occurs in test_colorbar.py test_colorbar_closed_patch. The effect of the bug there was to disable the ticks; but evidently this was considered a feature, because the example image was made with the bug in place, hence with no ticks on the colorbars. Therefore I have modified the test code to explicitly disable the ticks, so the test images don't have to be changed.
jklymak
approved these changes
Jan 6, 2019
|
It didn't--but the only test that went through that code path was oblivious to the fact that the ticks were missing as a result of the bug. I suspect I originally put the code in to make the class as general as possible, but it was not exercised in any normal use case. It could be removed entirely by disallowing the values kwarg in the case where boundaries are not also specified, and by changing the test that exercises that case. That would actually make the docstring a little more complicated, though. It might also make some other parts of the code more complicated; it's far from clear to me that it would be a net gain, without being part of a thorough rewriting of the colorbar code. |
timhoffm
approved these changes
Jan 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13098.
The unusual case of a call to colorbar with specified values
occurs in test_colorbar.py test_colorbar_closed_patch. The
effect of the bug there was to disable the ticks; but
evidently this was considered a feature, because the example
image was made with the bug in place, hence with no ticks on
the colorbars. Therefore I have modified the test code to
explicitly disable the ticks, so the test images don't have
to be changed.
PR Summary
PR Checklist