add animatplot to 3rd party packages list #13076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is going to need to be rebased onto the current master branch for the circleci builds to work. |
timhoffm
reviewed
Jan 5, 2019
e4a0e69 to
dcf91e2
Compare
|
@timhoffm Agreed. I made the image static, and I made a slightly smaller version of the animated gif and made it the cover for my docs. I didn't want to link directly to that example in my gallery since I am going to redo my gallery, and the link would break. |
|
You'll need to rebase and squash the two commits together to remove the old image. Or we squash merge this when complete. |
timhoffm
reviewed
Jan 6, 2019
doc/thirdpartypackages/index.rst
Outdated
|
|
||
| .. image:: /_static/animatplot.png | ||
|
|
||
| For an animated version of the above picture, see the animatplot docs |
There was a problem hiding this comment.
You could do
For an animated version of the above picture and more examples, see the
`animatplot gallery<https://animatplot.readthedocs.io/en/stable/gallery.html>`_
That should stay the same even if you reorganize your gallery.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds animatplot to the list of 3rd party packages. Closes animatplot #19.
I wasn't able to build the docs locally on my current machine, so someone will need to look at the CircleCI build artifact. The gif might break a latex build of the docs.