Don't explicitly add default include paths to Extensions #13064
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
This was referenced Dec 29, 2018
|
rebased now that #11964 is merged. |
QuLogic
reviewed
Feb 28, 2019
QuLogic
reviewed
Mar 1, 2019
QuLogic
approved these changes
Mar 5, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Mar 13, 2019
…ths to Extensions
|
attn @sandrotosi @cgohlke @msarahan don't think this will cause you problems, but just flagging this a head of 3.1 |
jklymak
added a commit
that referenced
this pull request
Mar 13, 2019
…064-on-v3.1.x Backport PR #13064 on branch v3.1.x (Don't explicitly add default include paths to Extensions)
6 tasks
thatch
added a commit
to third-party-oneoffs/matplotlib
that referenced
this pull request
Oct 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Closes #9737 and makes setupext.py 20% shorter.
Builds on top of #11964; once that PR is merged I'm happy to further split this one into smaller pieces to help review if needed.
PR Checklist