Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

Use default colour cycle in more examples #13063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jan 5, 2019
Merged

Use default colour cycle in more examples #13063

merged 6 commits into from
Jan 5, 2019

Conversation

dstansby
Copy link
Member

Makes lots of the examples look more pleasing to the eye!

timhoffm
timhoffm reviewed Dec 29, 2018
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically ok. However, I'm not a fan of using 'Cn' in cases that do not relate to a color sequence. Instead, we should use the color names 'tab:blue' etc instead. I've noted this down for one example but there are more similar cases in here.

examples/lines_bars_and_markers/joinstyle.py Outdated Show resolved Hide resolved
examples/lines_bars_and_markers/eventplot_demo.py Outdated Show resolved Hide resolved
@tacaswell tacaswell added this to the v3.1 milestone Dec 29, 2018
tacaswell
tacaswell approved these changes Dec 29, 2018
View reviewed changes
Copy link
Member

@tacaswell tacaswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with @timhoffm 's comments. 👍 on merging with those changes.

timhoffm
timhoffm reviewed Dec 29, 2018
View reviewed changes
examples/lines_bars_and_markers/eventcollection_demo.py Outdated Show resolved Hide resolved
timhoffm
timhoffm approved these changes Jan 4, 2019
View reviewed changes
Copy link
Member

@timhoffm timhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flake8 complains:

./examples/pyplots/pyplot_two_subplots.py:0:1: X100 Superfluous per-file-ignores for E302

Can be merged after that's fixed.

@timhoffm timhoffm merged commit a235538 into matplotlib:master Jan 5, 2019
@dstansby dstansby deleted the ex-col-cycle branch January 5, 2019 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tacaswell tacaswell tacaswell approved these changes

@timhoffm timhoffm timhoffm approved these changes

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@dstansby @tacaswell @timhoffm
Morty Proxy This is a proxified and sanitized view of the page, visit original site.